flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-34555][table] Migrate JoinConditionTypeCoerceRule to java.

Open liuyongvs opened this issue 1 year ago • 5 comments

What is the purpose of the change

The PR migrates JoinConditionTypeCoerceRule to java it doesn't touch JoinConditionTypeCoerceRuleTest to be sure that java version continues passing it

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

liuyongvs avatar Mar 01 '24 03:03 liuyongvs

CI report:

  • c9ac889cd6d3eebe84dbdadd0fb3ff70efe3caf2 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Mar 01 '24 03:03 flinkbot

@liuyongvs the ci still fails could you please have a look here?

snuyanzin avatar Apr 08 '24 09:04 snuyanzin

@liuyongvs the ci still fails could you please have a look here?

@snuyanzin The error occurs because the word "implicit" was mistakenly written as "Implicit", which leads to a compilation error in testLogicalPlanWithImplicitTypeCast, have fixed it

liuyongvs avatar Apr 09 '24 02:04 liuyongvs

hi @snuyanzin will you help review it?

liuyongvs avatar May 15 '24 05:05 liuyongvs

hi @snuyanzin ci passed

liuyongvs avatar Aug 28 '24 08:08 liuyongvs