flink icon indicating copy to clipboard operation
flink copied to clipboard

[DRAFT][FLINK-34516] Move CheckpointingMode to flink-core

Open Zakelly opened this issue 1 year ago • 1 comments

Do not merge this for now

What is the purpose of the change

In FLIP-406, we want to merge all options in ExecutionCheckpointingOptions to CheckpointingOptions, which depends on the CheckpointingMode being moved to flink-core as well. This PR introduce a new CheckpointingMode in flink-core, and deprecate the old one as well as corresponding user-facing APIs.

Brief change log

  • introduce a new CheckpointingMode in flink-core, providing new APIs.
  • deprecate the old CheckpointingMode in flink-streaming-java as well as the APIs.

Verifying this change

This change is already covered by new introduced UTs.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Zakelly avatar Feb 26 '24 13:02 Zakelly

CI report:

  • 45b7d3168890767a55c11c59f0fb5f3ae6b0eed2 UNKNOWN
  • 2e1eb71004bd348ee49c21fd63dc97a25f7c3587 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Feb 26 '24 13:02 flinkbot

@flinkbot run azure

Zakelly avatar Mar 13 '24 13:03 Zakelly

@masteryhx I have transformed to the new CheckpointMode everywhere, and rebased master. Would you please take a look?

Zakelly avatar Mar 14 '24 04:03 Zakelly

Rebased for conflicts....

Zakelly avatar Mar 14 '24 09:03 Zakelly

@flinkbot run azure

Zakelly avatar Mar 15 '24 07:03 Zakelly

@flinkbot run azure

Zakelly avatar Mar 15 '24 11:03 Zakelly

merged 8fac8046...77945916 into master

masteryhx avatar Mar 22 '24 03:03 masteryhx