flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-34454] Introduce StateRecoveryOptions in flink-core and Rename options

Open Zakelly opened this issue 1 year ago • 3 comments

What is the purpose of the change

As one part of FLIP-406, This PR introduce the StateRecoveryOptions in flink-core, and move & rename all state-recovery-related options into.

Brief change log

  • Introduce StateRecoveryOptions in flink-core.
  • Move all options of SavepointConfigOptions into StateRecoveryOptions and rename them.
  • Deprecate SavepointConfigOptions.
  • Move two options from ExecutionCheckpointingOptions into StateRecoveryOptions and rename them.
  • Re-generate the doc.

Verifying this change

This change is a trivial rework and is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Zakelly avatar Feb 22 '24 10:02 Zakelly

CI report:

  • bdbf9ff85e52da70efc2550987c0298468ee35ea Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Feb 22 '24 10:02 flinkbot

@fredia @masteryhx Would you please help review this?

Zakelly avatar Feb 23 '24 04:02 Zakelly

@fredia @masteryhx Thanks for your review! I've addressed your comments PTAL.

Zakelly avatar Feb 23 '24 11:02 Zakelly

Thanks for the update. Overall LGTM. Just minor suggestions:

  1. Update related docs from 'Restore Mode' to 'Claim Mode' to provide clearer guidance for users.
  2. Modifing codes like 'RestoreMode' in 2.0 is fine, it's better to add a TODO to provide clearer guidance for developers. WDYT?

Hi @masteryhx thanks for the suggestion! I have modified accordingly, PTAL.

Zakelly avatar Feb 26 '24 15:02 Zakelly