flink
flink copied to clipboard
[FLINK-34447][test] Hardens ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime
What is the purpose of the change
The purpose of ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime is unclear. The two code paths are covered by other tests:
#testWorkerRegistrationTimeout()checks the behavior if the registration times out (and the release logic kicks in)#testStartNewWorker()checks the happy path where the worker is deployed before the timeout triggers the release
Brief change log
- Removes test
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving): no - The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
CI report:
- 6217c89a5e8f5b9adad050030cdc44b20f95eacc Azure: SUCCESS
Bot commands
The @flinkbot bot supports the following commands:@flinkbot run azurere-run the last Azure build
@flinkbot run azure
@xintongsong Do you remember what the actual purpose of this test was? Am I missing something or can we actually remove this test because it might be unstable on slower machines. :thinking: