flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL

Open hackergin opened this issue 6 months ago • 4 comments

What is the purpose of the change

Outputting Identical Results in Mini-Batch Aggregation with Set TTL

Brief change log

  • Outputting Identical Results in Mini-Batch Aggregation with Set TTL including MiniBatchGlobalGroupAggFunction and MiniBatchGroupAggFunction

Verifying this change

This change added tests and can be verified as follows:

  • Extended unit test case in GroupAggregateHarnessTest#testAggregateWithRetraction that the aggregation results are the last result.
  • Add the unit test GroupAggregateHarnessTest#testGlobalAggregateWithRetraction including MiniBatchGlobalGroupAggFunction

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

hackergin avatar Feb 08 '24 07:02 hackergin

CI report:

  • 01ac5ba082e52fb0e50e990455b2ac48855c076d Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Feb 08 '24 07:02 flinkbot

@flinkbot run azure

hackergin avatar Feb 09 '24 16:02 hackergin

@xuyangzhong @fsk119 Please help review when you have time, thank you.

@jeyhunkarimov Do you have any other suggestions for this PR?

hackergin avatar Feb 26 '24 01:02 hackergin

@flinkbot run azure

hackergin avatar Feb 26 '24 01:02 hackergin

@xuyangzhong Thank you for the valuable suggestion. Following your advice, I have added relevant unit tests.

hackergin avatar Feb 28 '24 01:02 hackergin

@flinkbot run azure

hackergin avatar Jun 19 '24 09:06 hackergin

@flinkbot run azure

hackergin avatar Jun 19 '24 11:06 hackergin