flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-34401][docs-zh] Translate "Flame Graphs" page into Chinese

Open lxliyou001 opened this issue 1 year ago • 16 comments

What is the purpose of the change

Translate Flame Graphs to Chinese

Brief change log

The page is located at "docs/content.zh/docs/ops/debugging/flame_graphs.md"

Verifying this change

Docs only change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) bo

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

lxliyou001 avatar Feb 07 '24 02:02 lxliyou001

CI report:

  • 29a741b046a99e97ce4d853726a7d5fce3746bcd Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Feb 07 '24 02:02 flinkbot

@flinkbot run azure

lxliyou001 avatar Feb 07 '24 07:02 lxliyou001

@flinkbot run azure

lxliyou001 avatar Feb 07 '24 07:02 lxliyou001

Hi @JingGe , thank you for your advice, it is my first time participating in the Flink project. i have added 2 commits with your suggestion, Please review it when you have free time, thank you.

lxliyou001 avatar Feb 09 '24 13:02 lxliyou001

@flinkbot run azure

lxliyou001 avatar Feb 10 '24 00:02 lxliyou001

@flinkbot run azure

lxliyou001 avatar Feb 10 '24 04:02 lxliyou001

@flinkbot run azure

lxliyou001 avatar Feb 10 '24 07:02 lxliyou001

@flinkbot run azure

lxliyou001 avatar Feb 10 '24 10:02 lxliyou001

@flinkbot run azure

lxliyou001 avatar Feb 11 '24 12:02 lxliyou001

Could you rebase your branch?

JingGe avatar Feb 13 '24 00:02 JingGe

hi @JingGe , I have done with it, is that OK for you to merge this PR? thanks a lot.

lxliyou001 avatar Feb 17 '24 09:02 lxliyou001

hi @JingGe , I have done with it, is that OK for you to merge this PR? thanks a lot.

sure, let's wait until the CI passed

JingGe avatar Feb 20 '24 11:02 JingGe

@Zakelly 谢谢建议,还有这个pr没合入之前,每次master变更都要merge,然后merge又要过CI,CI耗时又很长,很是麻烦,我想问问CI在跑的过程中能合入吗

lxliyou001 avatar Feb 21 '24 09:02 lxliyou001

@Zakelly 谢谢建议,还有这个pr没合入之前,每次master变更都要merge,然后merge又要过CI,CI耗时又很长,很是麻烦,我想问问CI在跑的过程中能合入吗

如果是文档类的更改,确认不对CI造成影响的可以,committer可以合。master变更的话不用merge回你的更改分支哈,如果有更改可以继续提交commit即可。如果因为有冲突合不进去那需要进行rebase。

Zakelly avatar Feb 21 '24 09:02 Zakelly

@Zakelly 谢谢建议,还有这个pr没合入之前,每次master变更都要merge,然后merge又要过CI,CI耗时又很长,很是麻烦,我想问问CI在跑的过程中能合入吗

如果是文档类的更改,确认不对CI造成影响的可以,committer可以合。master变更的话不用merge回你的更改分支哈,如果有更改可以继续提交commit即可。如果因为有冲突合不进去那需要进行rebase。

好的,非常感谢

lxliyou001 avatar Feb 21 '24 09:02 lxliyou001

@flinkbot run azure

lxliyou001 avatar Feb 22 '24 15:02 lxliyou001

@JingGe could you please merge this PR, thanks

lxliyou001 avatar Feb 28 '24 11:02 lxliyou001

@lxliyou001 sure, would you like to squash your commits?

JingGe avatar Mar 05 '24 13:03 JingGe

@JingGe sure,could you help me do the "Squash and merge" action? thanks.

lxliyou001 avatar Mar 06 '24 06:03 lxliyou001