flink
flink copied to clipboard
[FLINK-34366][table] Add support to group rows by column ordinals
What is the purpose of the change
SImilar to BigQuery add support to group rows by column ordinals
Brief change log
- Calcite already supports groupby column ordinals. So, enable it
- Make sure that the config uses the updated SqlConformance
- Add tests
Verifying this change
Added tests to org.apache.flink.table.planner.runtime.stream.sql.AggregateITCase
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving)
: (no) - The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not documented)
CI report:
- b5b6b80b4fba7a2a38bbd8d032fb8c487d98ebf9 Azure: SUCCESS
Bot commands
The @flinkbot bot supports the following commands:-
@flinkbot run azure
re-run the last Azure build
@jeyhunkarimov Are you still working on this one?
Hi @MartijnVisser yes I am active on this and was waiting for a review.
Hi @twalthr thanks for your comments. Should I proceed with the FLIP process?
@jeyhunkarimov First, it would be great to identify the motivation behind this ticket. Is it just because we want to be compatible with BigQuery? How many vendors support it this way?