flink icon indicating copy to clipboard operation
flink copied to clipboard

[DRAFT][FLINK-33734] Merge unaligned checkpoint state handle

Open zoltar9264 opened this issue 1 year ago • 2 comments

What is the purpose of the change

Merge and serialize the state handles of unaligned checkpoint on TaskManager to potentially reduce checkpoint production time. Details in FLINK-33734.

Brief change log

  • Extract interface ChannelState,InputStateHandle,OutputStateHandle as mark of state handle of unaligned checkpoint
  • Introduce merged channel state handle
  • Extract interface ChannelStateHandleSerializer
  • Introduce MetadataV5Serializer for merged channel state handle
  • Merge and serialize channel state handle before send checkpoint ack to JobManager

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

zoltar9264 avatar Feb 02 '24 02:02 zoltar9264

CI report:

  • 1b1cda7c542ccbc599c67dee73a0bb62703acaea Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Feb 02 '24 02:02 flinkbot

@flinkbot run azure

zoltar9264 avatar Feb 18 '24 02:02 zoltar9264