flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-34094] Adds documentation for AsyncScalarFunction

Open AlanConfluent opened this issue 1 year ago • 3 comments

What is the purpose of the change

Adds documentation for AsyncScalarFunction.

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

AlanConfluent avatar Jan 30 '24 07:01 AlanConfluent

CI report:

  • 148a4dbe60acaa9ca17f3e68930b8969dd5c170c Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 30 '24 07:01 flinkbot

@AlanConfluent Can you look at @twalthr comments, so we can include this before the 1.19.0 release goes out?

MartijnVisser avatar Feb 05 '24 14:02 MartijnVisser

@MartijnVisser I updated the documentation. Please tell me if anything else is required to make the deadline.

AlanConfluent avatar Feb 10 '24 01:02 AlanConfluent