flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-34263] Converting double to decimal may fail

Open caicancai opened this issue 1 year ago • 3 comments

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-34263

Brief change log

Fix error description in documentation

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

caicancai avatar Jan 29 '24 12:01 caicancai

CI report:

  • e13d2621aea7f3f75978c83195078a295f56d94f Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 29 '24 12:01 flinkbot

@snuyanzin Hello, if you have time, can you help look at it? Thank you. This part of conversion is also reported wrong by default in calcite, which I have tested

caicancai avatar Jan 30 '24 06:01 caicancai

@snuyanzin PATL, thanks

caicancai avatar May 20 '24 07:05 caicancai