flink
flink copied to clipboard
[FLINK-34199] Add tracing for durations of rescaling/restoring RocksDB incremental checkpoints from downloaded and local state
What is the purpose of the change
This PR extends #24031 with traces for the rescaling/restore times from local state.
Brief change log
(for example:)
- The TaskInfo is stored in the blob store on job creation time as a persistent artifact
- Deployments RPC transmits only the blob storage reference
- TaskManagers retrieve the TaskInfo from the blob cache
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added integration tests for end-to-end deployment with large payloads (100MB)
- Extended integration test for recovery after master (JobManager) failure
- Added test that validates that TaskInfo is transferred only once across recoveries
- Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving)
: (yes / no) - The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
CI report:
- bc5b4a15e02d2a7848320e2e9bdc74b8b12dd392 Azure: FAILURE
Bot commands
The @flinkbot bot supports the following commands:-
@flinkbot run azure
re-run the last Azure build
I think the description is correct, depending on you point of view. Recovery today has two phases:
- If there is any remote state it will be downloaded and becomes local state.
- Then we either rescale or reopen the DB from local state.
And the PR is about measuring the 2nd phase (after we have already duration for the first).
Besides that, I already merged a PR that measures local/remote state sizes. And in our meeting we found that all of the metrics are useful :)
Right :sweat_smile: Then I guess the only confusion for me is about "local" in names and docs: remote state that is downloaded can be called "local", but it's pure implementation detail. It can't be used for local recovery yet; so it's not local from the user point of view.
I wrote the docs slightly different, hope that makes it clearer.