flink icon indicating copy to clipboard operation
flink copied to clipboard

[Draft][bugfix] Move the deserialization of shuffleDescriptor to a separate …

Open caodizhou opened this issue 1 year ago • 13 comments

…thread pool

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

caodizhou avatar Jan 17 '24 10:01 caodizhou

CI report:

  • ff7df82773ec479dd0066112765904172c248c13 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 17 '24 10:01 flinkbot

@flinkbot run azure

caodizhou avatar Jan 22 '24 02:01 caodizhou

@flinkbot run azure

caodizhou avatar Feb 08 '24 03:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 19 '24 04:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 19 '24 10:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 20 '24 03:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 20 '24 09:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 21 '24 02:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 21 '24 09:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 22 '24 11:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 23 '24 02:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 26 '24 02:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 26 '24 09:02 caodizhou

@flinkbot run azure

caodizhou avatar Feb 27 '24 11:02 caodizhou

Thanks for opening this fix PR! @caodizhou Is it ready to review, or is still in development or testing phase? (It is still annotated with "Draft".)

zhuzhurk avatar Feb 28 '24 03:02 zhuzhurk

Hi @caodizhou , is there any progress? Should we re-enable the excluded tests?

zhuzhurk avatar Mar 04 '24 08:03 zhuzhurk

cc @KarmaGYZ

zhuzhurk avatar Mar 05 '24 08:03 zhuzhurk