flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect

Open xiangforever2014 opened this issue 1 year ago • 6 comments

What is the purpose of the change

  • fix that passing ignore-unclaimed-state through dynamic props does not take effect

Brief change log

  • when parsing parameters of '-s' option to config map, just filter out the none setting to avoid replacing the value that comes from dynamic props.

Verifying this change

Documentation

  • Does this pull request introduce a new feature? (no)

xiangforever2014 avatar Jan 10 '24 06:01 xiangforever2014

CI report:

  • cb8764b35bc5205515d5a1ce9944ddaf697b2599 Azure: FAILURE
  • 16abe8bde7790cffd4a383e1a05a870bb8e0c99f UNKNOWN
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 10 '24 06:01 flinkbot

Thanks for the pr. PTAL my comments. BTW, Could we also provide a UT to verify this ?

Sorry to reply so late, I have refactor the code according to your comments, and add some unit tests to verify the behavior.

xiangforever2014 avatar Jan 24 '24 08:01 xiangforever2014

@flinkbot run azure

xiangforever2014 avatar Jan 24 '24 12:01 xiangforever2014

@flinkbot run azure

xiangforever2014 avatar Jan 30 '24 02:01 xiangforever2014

@flinkbot run azure

xiangforever2014 avatar Jan 31 '24 06:01 xiangforever2014

Sorry for jumping in but I have mixed feelings... Is this a common problem that also applies for other options and shall we implement a generic solution for all similar options.

Zakelly avatar Feb 20 '24 15:02 Zakelly