flink
flink copied to clipboard
[FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect
What is the purpose of the change
- fix that passing ignore-unclaimed-state through dynamic props does not take effect
Brief change log
- when parsing parameters of '-s' option to config map, just filter out the none setting to avoid replacing the value that comes from dynamic props.
Verifying this change
Documentation
- Does this pull request introduce a new feature? (no)
CI report:
- cb8764b35bc5205515d5a1ce9944ddaf697b2599 Azure: FAILURE
- 16abe8bde7790cffd4a383e1a05a870bb8e0c99f UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:@flinkbot run azurere-run the last Azure build
Thanks for the pr. PTAL my comments. BTW, Could we also provide a UT to verify this ?
Sorry to reply so late, I have refactor the code according to your comments, and add some unit tests to verify the behavior.
@flinkbot run azure
@flinkbot run azure
@flinkbot run azure
Sorry for jumping in but I have mixed feelings... Is this a common problem that also applies for other options and shall we implement a generic solution for all similar options.