flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33759] [flink-parquet] Add support for nested array with row type

Open ukby1234 opened this issue 1 year ago • 5 comments

What is the purpose of the change

This is to support parquet file writes with nested array with struct type.

Brief change log

  • add support for nested array with row type

Verifying this change

This change added tests and can be verified as follows:

  • Added test that validates that nested array with row type can be written

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

ukby1234 avatar Jan 05 '24 06:01 ukby1234

This adds the missing case for https://github.com/apache/flink/pull/23881

ukby1234 avatar Jan 05 '24 06:01 ukby1234

CI report:

  • 9a1e4e09231c900f8e7d91e1fbcbb4dca5dc2bd1 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 05 '24 06:01 flinkbot

@MartijnVisser can you help review this PR? and possibly https://github.com/apache/flink/pull/23881 as well?

ukby1234 avatar Mar 13 '24 01:03 ukby1234

Hi, we're having this exact issue in our team and found this PR fixing it, is there a expected timeframe for this to be merged? If any help is needed to test/review this I'm happy to help.

ViktorCosenza avatar May 08 '24 16:05 ViktorCosenza

Yes I would love to have review/test on this PR.

ukby1234 avatar May 08 '24 19:05 ukby1234