flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33979] Implement restore tests for TableSink node

Open bvarghese1 opened this issue 1 year ago • 2 comments

What is the purpose of the change

Add restore tests for TableSink node

Verifying this change

This change added tests and can be verified as follows:

  • Added restore tests for TableSink node which verifies the generated compiled plan with the saved compiled plan.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

bvarghese1 avatar Jan 04 '24 01:01 bvarghese1

CI report:

  • cb3c3e9b83136b35d682db2d30971b3c03eeccc0 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 04 '24 01:01 flinkbot

Similar to the table source PR, I peeked at SinkAbilitySpec.

Looks like OverwriteSpec, PartitioningSpec, and WritingMetadataSpec are covered.

I wonder if we should try and cover RowLevelDeleteSpec and RowLevelUpdateSpec?

jnh5y avatar Jan 04 '24 17:01 jnh5y