flink icon indicating copy to clipboard operation
flink copied to clipboard

[hotfix] [docs, RestartStrategyOptions]: update the default value of "restart-strategy.fixed-delay.attempts" to 1 in docs

Open niliushall opened this issue 1 year ago • 3 comments

What is the purpose of the change

The default value of restart-strategy.fixed-delay.attempts in RestartStrategyOptions.java is 1, but the value of the parameter in the description of restart-strategy.type and the content of task_failure_recovery.md is Integer.MAX_VALUE. To ensure the consistency of the description and code, the above content should be modified.

The versions with the above problems are: 1.14 -> latest version

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive):no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

niliushall avatar Jan 01 '24 10:01 niliushall

CI report:

  • 155b1b1f022fe079660bf7283bf2c3a4d108f57f Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 01 '24 10:01 flinkbot

@roncohen @hadronzoo @is @rehevkor5 Could you please take a look at this pr in your free time? Thanks~

niliushall avatar Jan 01 '24 10:01 niliushall

Thanks for the PR! I suggest creating a jira ticket for this. And it would be better if the description in org.apache.flink.configuration.RestartStrategyOptions is also fixed.

Zakelly avatar Feb 20 '24 14:02 Zakelly