flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33958] Implement restore tests for IntervalJoin node

Open bvarghese1 opened this issue 1 year ago • 3 comments

What is the purpose of the change

Add restore tests for IntervalJoin node

Verifying this change

This change added tests and can be verified as follows:

  • Added restore tests for IntervalJoin node which verifies the generated compiled plan with the saved compiled plan.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

bvarghese1 avatar Dec 29 '23 03:12 bvarghese1

CI report:

  • 98db00dc90477da9989a77d1417ea3d463d7b131 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Dec 29 '23 03:12 flinkbot

From reading the code for StreamExecIntervalJoin, I noticed pad/filter-left/right transformations. Seems like those can be produced when the TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS is used.

Since it is a legacy thing, not sure if we want to test it or not.

jnh5y avatar Jan 04 '24 17:01 jnh5y

From reading the code for StreamExecIntervalJoin, I noticed pad/filter-left/right transformations. Seems like those can be produced when the TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS is used.

Since it is a legacy thing, not sure if we want to test it or not.

TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS is a deprecated config. It is used in the createNegativeWindowSizeJoin function and I have added a test case which covers that path.

bvarghese1 avatar Jan 12 '24 03:01 bvarghese1