flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation

Open zhengzhili333 opened this issue 2 years ago • 4 comments

What is the purpose of the change

Currently, submitting a job starts with storing the JobGraph (in HA setups) in the JobGraphStore. This includes writing the file to S3 (or some other remote file system). The job submission is done in the Dispatcher's main thread. If writing the JobGraph is slow, it would block any other operation on the Dispatcher.

Brief change log

  • The dispatcher put JobGraph asynchronously in ioExecutor
  • The dispatcher write To ExecutionGraphInfoStore asynchronously in ioExecutor
  • The JobGraphWriter interface class adds a putJobGraphAsync method for asynchronous write operations
  • Implementation class DefaultJobGraphStore adds the putJobGraphAsync method for asynchronous write operations

Verifying this change

This change added tests and can be verified as follows:

  • Added the Dispatcher JobSubmission test, use ZooKeeperStateHandleStore as JobGraphStore
  • Added the Dispatcher JobSubmission test, use KubernetesStateHandleStore as JobGraphStore

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

zhengzhili333 avatar Dec 06 '23 03:12 zhengzhili333

CI report:

  • 0a311c4bac76219d1936dad3d1d54f850518df9a Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Dec 06 '23 03:12 flinkbot

Thank you for your suggestion, I have modified that interface and also corrected the point you mentioned earlier.

zhengzhili333 avatar Dec 15 '23 02:12 zhengzhili333

@zhengzhili333 sorry for the delay. But can you rebased the branch and remove any merge commits? That would help with the review

XComp avatar Feb 21 '24 11:02 XComp

@XComp I created a new pr,https://github.com/apache/flink/pull/24366 Please review it when you have time.

zhengzhili333 avatar Feb 23 '24 01:02 zhengzhili333