flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33576][core] Introduce new Flink conf file 'config.yaml' supporting standard YAML syntax.

Open JunRuiLee opened this issue 1 year ago • 4 comments

What is the purpose of the change

Introduce new Flink conf file 'config.yaml' supporting standard YAML syntax.

Brief change log

  • Introduce new Flink conf file 'config.yaml' supporting standard YAML syntax.
  • Change the UT case to use new conf file.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

JunRuiLee avatar Dec 01 '23 10:12 JunRuiLee

CI report:

  • 7f422b491adbee56d9dfa3f346167cbdfdc88ada Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Dec 01 '23 10:12 flinkbot

Hi @zhuzhurk , Thanks for reviewing. I've updated the PR with the necessary changes. Please take a look~

Here are some clarifications I'd like to make:

  1. Concerning the thread safety issues of the GlobalConfiguration.isStandardYaml state during concurrent tests, the current testing framework in Flink ensures tests are run sequentially between different test classes within the same process. This setup means we only need to ensure the consistency of that state upon the completion of each test class.

  2. Regarding the updates needed for comments within the code and specific code references to "flink-conf.yaml" (for example, in YarnTestBase), I intend to address these adjustments in a follow-up task. This subsequent task will involve updating the default configuration file in flink-dist to config.yaml, at which time I plan to collectively revise both the comments in the code and the relevant code references.

JunRuiLee avatar Jan 11 '24 09:01 JunRuiLee

@zhuzhurk I've updated this pr accordingly, PTAL.

JunRuiLee avatar Jan 11 '24 11:01 JunRuiLee

@flinkbot run azure

JunRuiLee avatar Jan 12 '24 03:01 JunRuiLee

@flinkbot run azure

JunRuiLee avatar Jan 15 '24 03:01 JunRuiLee