flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33705] Upgrade to flink-shaded 18.0

Open snuyanzin opened this issue 2 years ago • 2 comments

What is the purpose of the change

The PR is to bump flink-shaded dependency to 18.0 Also there was a breaking change in jackson-databind https://github.com/FasterXML/jackson-databind/issues/3651 which moves the logic for scientific notation from JsonNodeFactory to JsonNodeDeserializer. The problem is that in flink-csv and flink-json for converters bare JsonNodeFactory is used and this is impacted. The PR adopts the code

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes )
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

snuyanzin avatar Nov 30 '23 10:11 snuyanzin

CI report:

  • f733fbcaba675f3128bf766e8bfa34093c8e54cb Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Nov 30 '23 10:11 flinkbot

@flinkbot run azure

snuyanzin avatar Jan 10 '24 15:01 snuyanzin

Thanks for having a look I will rebase to the latest branch and ~~split it in 2 commits: one for adopting jackson breaking change mentioned in description and another for the actual update. It should simplify code navigation in future~~

Oops splitting will not work since code for breaking change adoption requires already jackson 2.15.x..., so will keep in one commit

snuyanzin avatar Jan 12 '24 07:01 snuyanzin