flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-29420][Build] Upgrade Zookeeper to 3.7.2

Open MartijnVisser opened this issue 2 years ago • 3 comments

What is the purpose of the change

  • Update Zookeeper to 3.7.2

Brief change log

  • Updated POM and testcontainer setup

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

MartijnVisser avatar Nov 17 '23 09:11 MartijnVisser

CI report:

  • 7f773d4ed30a91d6877cd1e37024d7c5b9a4eb25 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Nov 17 '23 09:11 flinkbot

@MartijnVisser I took a look. It seems that the failed reason is that version 3.7.2 of flink-shaded-zookeeper-3 has not been released/supported.(https://github.com/apache/flink-shaded/blob/d18d236329cecd1dbad8ceba470d8b30f2e8ffd4/flink-shaded-zookeeper-parent/flink-shaded-zookeeper-37/pom.xml#L36)

TanYuxin-tyx avatar Nov 21 '23 02:11 TanYuxin-tyx

Hello, this PR is important because there is a CVE ( CVE-2023-44981 ) on zookeeper < 3.7.2

yazgoo avatar Jun 20 '24 09:06 yazgoo

superseded by https://github.com/apache/flink/commit/7e11de657153eb31de8e8c0cfbabce365eb1c57e#diff-d746de8964721a0a7ecfe91df19d3c5047d2adc9ba35384e2f751524037392ec

snuyanzin avatar Dec 05 '24 21:12 snuyanzin