flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33428] Flink SQL CEP support 'followed','notNext' and 'notFollowedBy' semantics

Open ValjeanShaw opened this issue 2 years ago • 3 comments

1.Use the {- -} extension to expand the follow semantics. 2.add the "[^ ]" extension to expand the notNext and notFollowedBy semantics.

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

ValjeanShaw avatar Nov 01 '23 11:11 ValjeanShaw

CI report:

  • 6e0578bce11ab321acb53a0a02e4f237e799ab58 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Nov 01 '23 11:11 flinkbot

Like I've commented in the Jira ticket, I think we should first have discussion on the Dev mailing list and perhaps even a FLIP on the mailing list. This does look really promising.

Edit: Also, this improvement needs to be targeted against master, not against release-1.16.

MartijnVisser avatar Nov 01 '23 12:11 MartijnVisser

Like I've commented in the Jira ticket, I think we should first have discussion on the Dev mailing list and perhaps even a FLIP on the mailing list. This does look really promising.

Edit: Also, this improvement needs to be targeted against master, not against release-1.16.

PR's Comments received. As described in Jira, I initiated a discussion on the Dev mailing list.

ValjeanShaw avatar Nov 06 '23 11:11 ValjeanShaw

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 04 '25 06:04 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar May 05 '25 06:05 github-actions[bot]