flink
flink copied to clipboard
apache
[FLINK-31481][table] Support enhanced show databases syntax
What is the purpose of the change
Support enhanced show functions syntax described in FLIP-297
Brief change log
Changelog from:
SHOW DATABASES
to:
SHOW DATABASES [ ( FROM | IN ) catalog_name] [ [NOT] (LIKE | ILIKE) <sql_like_pattern> ]
Verifying this change
- Extended integration tests
flink-table/flink-sql-client/src/test/resources/sql/catalog_database.q - Extended unit test
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java -> testShowDataBases() - Added unit tests in
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlOtherOperationConverterTest.java -> testShowDatabases()
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving): no - The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
CI report:
- 29cb2f61afe6241ed826ebd4ebaea79cc9c10987 Azure: SUCCESS
Bot commands
The @flinkbot bot supports the following commands:-
@flinkbot run azurere-run the last Azure build
This is looking pretty good. Since implementing FLIP-297 is assigned to @chucheng92, we should get his input as well!
@jeyhunkarimov have you signed up for the Flink JIRA? You may need to request access on the Flink dev list. (I tried to find instructions, but I am not seeing them immediately.)
This is looking pretty good. Since implementing FLIP-297 is assigned to @chucheng92, we should get his input as well!
@jeyhunkarimov have you signed up for the Flink JIRA? You may need to request access on the Flink dev list. (I tried to find instructions, but I am not seeing them immediately.)
@jeyhunkarimov good work! Currently i'm busy with other work, feel free to assign to yourself.
Thanks for the comment @chucheng92 and thank you for the review @jnh5y .
I addressed your comments. Could you please check if you have any other comments?
P.s I have jira account (jID: jeyhunkarimov). I can assign tasks to myself in other apache projects (e.g., kafka). However, in Flink this is not possible. I will ask for the required permissions via dev mailing list.
Hi @jnh5y could you please check if your comments are addressed? Thanks!
Hi @jnh5y could you please check if your comments are addressed? Thanks!
Hi @jeyhunkarimov, sorry to be slow to look again. Things are looking good. @dawidwys would you be willing to take a quick read through. I've left some comments where I think you could provide some insight about what needs to change for this work to be merged.