flink
flink copied to clipboard
[FLINK-30081][runtime] Reset jvm-overhead.min/max for local executor
What is the purpose of the change
https://issues.apache.org/jira/browse/FLINK-30081
In local executor, it's not possible to set different values for taskmanager.memory.jvm-overhead.max
and taskmanager.memory.jvm-overhead.min
. When setting them differently, local executor reports Exception in thread "main" java.lang.IllegalArgumentException
error.
The problem was that we expect the max and min to equal, but they are not resolved to the same value for local executor. Actually the two values are not effective for local, we should reset them to the same value.
Brief change log
- reset the two JVM overhead config to the same value for local executor
- fix a bug in l
Verifying this change
This change is already covered by existing tests, such as TaskExecutorResourceUtilsTest
. It also adds a new test case in this class.
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving)
: (yes / no) - The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
CC: @xintongsong for review. Thanks!
CI report:
- 64968583a1b6644803fe629f2a809f9fb4051092 Azure: SUCCESS
Bot commands
The @flinkbot bot supports the following commands:-
@flinkbot run azure
re-run the last Azure build