flink
flink copied to clipboard
[FLINK-31380][table] Support enhanced show catalogs syntax
What is the purpose of the change
Support enhanced show catalogs syntax for FLIP-297
Brief change log
Support enhanced show catalogs syntax:
SHOW CATALOGS [ [NOT] (LIKE | ILIKE) <sql_like_pattern> ]
Verifying this change
Add cases in FlinkSqlParserImplTest:
- testShowCatalogs
Add cases in SqlOtherOperationConverterTest:
- testShowCatalogs
sql-client & sql-client-gateway: catalog_databases.q
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving): no - The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
CI report:
- 676753e6211927577ef91e15ab3ad7fe8622a9e4 Azure: SUCCESS
Bot commands
The @flinkbot bot supports the following commands:@flinkbot run azurere-run the last Azure build
@wuchong hi, jark. I added a lot of test cases and did integration testing for a while. Can u help me to review this feature?
@wuchong hi, jark. I added a lot of test cases and did integration testing for a while. Can u help me to review this feature?
cc @wuchong PTAL~
@Aitozi hi, Considering using a SupportLike parent class may make confused, i have changed and rebased the code. thanks for reviewing.
Hi @chucheng92 , thanks for the contribution. Considering the community is moving the execution logic out from TableEnvironmentImpl to reduce the maintenance cost (see FLINK-31368).
The migration of ShowOptions is opened in #22215, could you wait and rebase the implementation on that? And would be appreciated if you could help to review #22215.
Hi @chucheng92 , https://github.com/apache/flink/pull/22215 has been merged, could you rebase this pull request?
@wuchong @Aitozi hi, guys. sorry to bother you, can you help to re-check it?
@Aitozi Sorry to pin you, all your comments have been addressed, can you help to re-check it ? thanks.
@wuchong @luoyuxia hi, Jark, yuxia. Another PR ShowFunctions has been merged, I picked some common logics and rebased master, can u help to review this PR?
Hi @chucheng92 thanks for your contribution and sorry for the long delay
there was a refactoring for show operations within FLINK-36085 to extract common logic Do you mind to adapt the PR to that or do you mind if I will do that and you can then review the changes?
Hi @snuyanzin thanks, got it, I'll update this PR to use that common logic and complete this PR soon.
hi @snuyanzin, I have updated the PR to adapt to FLINK-36085. If you have time, please take a look. thanks.
hi @snuyanzin all comments resolved. If you have time, PTAL. thanks
@chucheng92 thanks for the contribution @Aitozi thanks for participation in review LGTM