flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCas…

Open SmirAlex opened this issue 3 years ago • 1 comments

What is the purpose of the change

This is a backport of PR 20734

Fixed unstable test LookupJoinITCase with Full cache

Brief change log

  • Avoided concurrent creation of Projection object from generated code
  • Fixed closing logic, so now close method waits until current reload is over+ there can't be another reload after closing
  • Reset resource counter in LookupJoin IT cases before each test, so if one will be failed, other ones will not be affected by that

Verifying this change

This change is already covered by existing tests, such as LookupJoinITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? not documented)

SmirAlex avatar Sep 23 '22 06:09 SmirAlex

CI report:

  • 7e9d69912530982333b4833d83c06294d32aad80 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 23 '22 06:09 flinkbot

The CI failed because of an unrelated issue FLINK-29315. Merging to release-1.16

PatrickRen avatar Sep 23 '22 14:09 PatrickRen