flink
flink copied to clipboard
[FLINK-29372] Add suffix to all options that conflict with YAML
We have a few options where the key is a prefix of other options (e.g., high-availability and high-availability.cluster-id.
Add a suffix to these options and keep the old key as deprecated.
CI report:
- 3049e3c1db68c2cbc8525740be017724486f495d UNKNOWN
- 233e6ee02062b470caea60a319f38cd5b04f9c55 Azure: SUCCESS
Bot commands
The @flinkbot bot supports the following commands:-
@flinkbot run azure
re-run the last Azure build
Is it possible to guard against regression in the case of new config keys with some test? Maybe running through a different YAML parser?
Is it possible to guard against regression in the case of new config keys with some test? Maybe running through a different YAML parser?
We could collect all keys and verify that none is a prefix of another key. That is quite simple (and how I found the offending options).
Following configuration options are missing:
kubernetes.jobmanager.cpu
, is the prefix of kubernetes.jobmanager.cpu.limit-factor
kubernetes.taskmanager.cpu
, is the prefix of kubernetes.taskmanager.cpu.limit-factor
@flinkbot run azure
Added a test, which found a few more violations.