flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-29372] Add suffix to all options that conflict with YAML

Open zentol opened this issue 1 year ago • 5 comments

We have a few options where the key is a prefix of other options (e.g., high-availability and high-availability.cluster-id.

Add a suffix to these options and keep the old key as deprecated.

zentol avatar Sep 21 '22 07:09 zentol

CI report:

  • 3049e3c1db68c2cbc8525740be017724486f495d UNKNOWN
  • 233e6ee02062b470caea60a319f38cd5b04f9c55 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 21 '22 07:09 flinkbot

Is it possible to guard against regression in the case of new config keys with some test? Maybe running through a different YAML parser?

austince avatar Sep 21 '22 13:09 austince

Is it possible to guard against regression in the case of new config keys with some test? Maybe running through a different YAML parser?

We could collect all keys and verify that none is a prefix of another key. That is quite simple (and how I found the offending options).

zentol avatar Sep 21 '22 13:09 zentol

Following configuration options are missing: kubernetes.jobmanager.cpu, is the prefix of kubernetes.jobmanager.cpu.limit-factor kubernetes.taskmanager.cpu, is the prefix of kubernetes.taskmanager.cpu.limit-factor

wanglijie95 avatar Sep 22 '22 06:09 wanglijie95

@flinkbot run azure

zentol avatar Sep 22 '22 08:09 zentol

Added a test, which found a few more violations.

zentol avatar Sep 23 '22 12:09 zentol