flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-29339][runtime] JobMasterPartitionTracker returns future to avoid blocking main thread

Open Sxnan opened this issue 2 years ago • 4 comments

What is the purpose of the change

JobMasterPartitionTracker#getClusterPartitionShuffleDescriptors returns future to avoid blocking the main thread.

Brief change log

  • JobMasterPartitionTracker#getClusterPartitionShuffleDescriptors returns future to avoid blocking the main thread.
  • Adjust TaskDeploymentDescriptorFactory so that createDeploymentDescriptor returns a future of DeploymentDescriptor.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializer: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Sxnan avatar Sep 20 '22 08:09 Sxnan

CI report:

  • 04a451fc688ea997c64d18e88588834ccf1da94c Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 20 '22 08:09 flinkbot

@flinkbot run azure

Sxnan avatar Sep 21 '22 07:09 Sxnan

@flinkbot run azure

Sxnan avatar Sep 21 '22 10:09 Sxnan

@flinkbot run azure

Sxnan avatar Sep 22 '22 02:09 Sxnan

@Sxnan Could you have a look at the above issue first ?

gaoyunhaii avatar Oct 27 '22 07:10 gaoyunhaii

@gaoyunhaii Thanks for your review and sorry for the late update. I updated the PR accordingly. Could you please take another look?

Sxnan avatar Dec 14 '22 06:12 Sxnan