flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-26943] [add date_add function support]

Open y0908105023 opened this issue 3 years ago • 2 comments

What is the purpose of the change

Add date_add sql function support

Brief change log

date_add

  • add sql function date_add to BuiltInFunction
  • also support streaming function date_add

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

This change is already covered by existing tests, such as (please describe tests).

ScalarFunctionsTest#testDateTypeAdd

ScalarFunctionsTest#testDateTypeMinus

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

It does not affect any parts

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

No

y0908105023 avatar Sep 16 '22 06:09 y0908105023

CI report:

  • 5c498adb0a4a6fa2428514c27fa82a4124264e36 Azure: FAILURE
  • 2c5e218120e9d6959f89f2af4d18e42269b00aa4 Azure: PENDING
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 16 '22 07:09 flinkbot

Thanks for contribution. It would be great if you fill PR template accordingly. In this case, the commit message could also be improved to meet the Code Style & Quality Guidelines, which can be found at https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html. Please be explicit in which type name you are correcting and where

snuyanzin avatar Sep 21 '22 11:09 snuyanzin

@snuyanzin i request a new pr: https://github.com/apache/flink/pull/20901. thaks for your time.

y0908105023 avatar Sep 26 '22 11:09 y0908105023