flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-29309][streaming-java] Relax allow-client-job-configurations for Table API and parameters

Open twalthr opened this issue 3 years ago • 2 comments

What is the purpose of the change

This is the second and hopefully last iteration on the allow-client-job-configurations feature. This PR makes sure that both Table API and DataStream API work as expected. It also provide infrastructure to allow certain options nevertheless. Currently, only global job parameters but this is most likely also the most important option.

Brief change log

  • Relax constraint and allow StreamExecutionEnvironment.getEnvironment(Configuration)
  • Allow global job parameters and infra for more in the future
  • Add more documentation

Verifying this change

This change added tests and can be verified as follows: StreamContextEnvironmentTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? JavaDocs

twalthr avatar Sep 15 '22 14:09 twalthr

CI report:

  • 6df29c15258b6cadb42642695dd04a81b9650d44 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 15 '22 14:09 flinkbot

nit: test suite fails with https://issues.apache.org/jira/browse/FLINK-29315

dmvk avatar Sep 19 '22 07:09 dmvk