flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

Open swuferhong opened this issue 1 year ago • 2 comments

What is the purpose of the change

This PR is aims to fix cannot generate plan error when insert a sorted view into multi sinks. The error is caused by the sort information in traitSet do not pass to IntermediateRelTable when block optimize. So I override getCollationList method in IntermediateRelTable to get new traitSet include sort information.

Brief change log

  • Override getCollationList method in IntermediateRelTable to get new traitSet include sort information.
  • Adding UT test for this case.
  • Adding ITCase for this case.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no docs.

swuferhong avatar Sep 13 '22 07:09 swuferhong

@godfreyhe @lincoln-lil Could you review this pr ? Thanks !

swuferhong avatar Sep 13 '22 07:09 swuferhong

CI report:

  • 7de26b83d50afaddb3ddeadf3d5421d717c35798 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 13 '22 07:09 flinkbot

@flinkbot run azure

fsk119 avatar Jan 10 '23 01:01 fsk119