flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-29195] Expose lastCompletedCheckpointId metric

Open chenyuzhi459 opened this issue 2 years ago • 7 comments

What is the purpose of the change

Expose the lastCheckpointId metric.

Brief change log

  • Register LatestCompletedCheckpointIdGauge named "lastCheckpointId" to CheckpointStatsTracker

Verifying this change

This change is already covered by existing tests, such as CheckpointStatsTrackerTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

chenyuzhi459 avatar Sep 08 '22 02:09 chenyuzhi459

CI report:

  • addb6fa7250f8a833957146a60bd5a4fd2a6590f Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 08 '22 02:09 flinkbot

@flinkbot run azure

chenyuzhi459 avatar Sep 09 '22 11:09 chenyuzhi459

@flinkbot run azure

chenyuzhi459 avatar Sep 10 '22 01:09 chenyuzhi459

LGTM, @curcur Do you have other comments ?

masteryhx avatar Sep 13 '22 10:09 masteryhx

Please also update the title and description correspondingly.

curcur avatar Sep 13 '22 11:09 curcur

@flinkbot run azure

chenyuzhi459 avatar Sep 14 '22 13:09 chenyuzhi459

@flinkbot run azure

chenyuzhi459 avatar Sep 15 '22 01:09 chenyuzhi459

I do not have other comments, please update the commit msg, and I will merge the code.

curcur avatar Sep 27 '22 11:09 curcur

@flinkbot run azure

chenyuzhi459 avatar Sep 28 '22 10:09 chenyuzhi459

The commit-msg needs to be changed to

[FLINK-29195][runtime/Checkpoint] Expose lastCompletedCheckpointId metric

@curcur ok, I have fixed it.

chenyuzhi459 avatar Sep 29 '22 02:09 chenyuzhi459

Thanks for fixing up this @chenyuzhi459

curcur avatar Oct 20 '22 07:10 curcur