flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-29215][Table SQL/API] Use config based constructors for converter rules instead of deprecated

Open snuyanzin opened this issue 3 years ago • 1 comments

What is the purpose of the change

Currently used constructors became deprecated at https://issues.apache.org/jira/browse/CALCITE-3923 The PR makes converters rules use Config based constructors instead of deprecated following instructions from Calcite https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/plan/RelRule.java#L45-L114

Brief change log

  • Converters rules
  • misprint in FlinkAggregateRemoveRule.java
  • unused import in AggregateJoinTransposeITCase.scala

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

snuyanzin avatar Sep 06 '22 22:09 snuyanzin

CI report:

  • 02654ea6f5ffd1796a896b5942eb65692f286b83 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 06 '22 22:09 flinkbot

@flinkbot run azure

snuyanzin avatar Oct 21 '22 16:10 snuyanzin

Thanks for the feedback, rebased

snuyanzin avatar Jan 24 '23 15:01 snuyanzin