flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-29214][Table API/SQL] Remove usages of deprecated Aggregate#indicator

Open snuyanzin opened this issue 3 years ago • 3 comments

What is the purpose of the change

In https://issues.apache.org/jira/browse/CALCITE-2944 Aggregate#indicator was made always false and deprecated. The PR removes usages of this

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

snuyanzin avatar Sep 06 '22 21:09 snuyanzin

CI report:

  • 405d2622e0378ebbb5cdc9ff6d3e498f81831e22 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 06 '22 21:09 flinkbot

@flinkbot run azure

snuyanzin avatar Sep 07 '22 00:09 snuyanzin

@flinkbot run azure

snuyanzin avatar Sep 07 '22 05:09 snuyanzin

@flinkbot run azure

snuyanzin avatar Oct 21 '22 17:10 snuyanzin

@flinkbot run azure

snuyanzin avatar Dec 16 '22 18:12 snuyanzin

@lincoln-lil sorry for the poke since you one of the active contributors to table-planner, may I ask you to have a look?

snuyanzin avatar Feb 06 '23 13:02 snuyanzin

merged as 0412329dea41d8f1325b6eefc2ab0914142be007

snuyanzin avatar Apr 18 '23 22:04 snuyanzin