flink
flink copied to clipboard
apache
[FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCase + reset resource counter before each test
What is the purpose of the change
Fixed unstable test LookupJoinITCase with Full cache
Brief change log
- Avoided concurrent creation of
Projectionobject from generated code - Fixed closing logic, so now
closemethod waits until current reload is over+ there can't be another reload after closing - Reset resource counter in LookupJoin IT cases before each test, so if one will be failed, other ones will not be affected by that
Verifying this change
This change is already covered by existing tests, such as LookupJoinITCase.
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (no) - The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? not documented)
CI report:
- a115ab9592fb5ab8d7f3035d66eaba3e6446d3d5 Azure: FAILURE
Bot commands
The @flinkbot bot supports the following commands:-
@flinkbot run azurere-run the last Azure build
Successful pipeline - https://dev.azure.com/asmirnov1/Flink/_build/results?buildId=35&view=results
Successful pipeline after update - https://dev.azure.com/asmirnov1/Flink/_build/results?buildId=36&view=results
Hi @PatrickRen, I updated the PR according to your comments. About closing of InputFormats - they are closed in the finally block of InputSplitCacheLoadTask#run. Also I added checks for open-closed counter in all tests with FullCacheTestInputFormat.
The CI failed because of an unrelated issue FLINK-29315. Merging to master
