flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-28750][Hive]The field comment for hive ddl has logic error

Open hehuiyuan opened this issue 2 years ago • 2 comments

What is the purpose of the change

The field comment is lost when using hive parser. There are som logic error for parsering hive sql

"set table.sql-dialect=hive;\n" +
"CREATE TABLE IF NOT EXISTS myhive.dev.shipu3_test_1125 (\n" +
"   `id` int COMMENT 'iadddd',\n" +
"   `cartdid` bigint COMMENT 'aaa',\n" +
"   `customer` string COMMENT 'vvvv',\n" +
"   `product` string COMMENT 'cccc',\n" +
"   `price` double COMMENT '',\n" +
"   `dt` STRING COMMENT ''\n" +
") PARTITIONED BY (dt STRING) STORED AS TEXTFILE TBLPROPERTIES (\n" +
"  'streaming-source.enable' = 'false',\n" +
"  'streaming-source.partition.include' = 'all',\n" +
"  'lookup.join.cache.ttl' = '12 h'\n" +
")"; 

image

Brief change log

Add field comment for hive ddl

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

hehuiyuan avatar Aug 11 '22 08:08 hehuiyuan

CI report:

  • ae6c31ff1a6ca69fa21255fd8fa233966faecfe4 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Aug 11 '22 08:08 flinkbot

Hi @luoyuxia @beyond1920 , does it need to be repaired in 1.14?

hehuiyuan avatar Aug 11 '22 13:08 hehuiyuan