flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-28860] Fix CacheITCase

Open Sxnan opened this issue 2 years ago • 3 comments

What is the purpose of the change

The PR address the two problems that cause CacheITCase to fail randomly.

  • Cache consumption in stream mode should recompute the result in case of cache miss instead of throwing an exception.
  • JobMaster waits for the acknowledgment of partition release and promotion before reaching the globally terminal state. Otherwise, partitions that should be promoted may be released.

Brief change log

  • Cache consumption in stream mode recompute result in case of cache miss
  • JobMaster wait for partition release and promote before close

Verifying this change

This change is already covered by existing tests, such as CacheITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Sxnan avatar Aug 10 '22 08:08 Sxnan

CI report:

  • ddf38e52b7fadae308337a6546ef1abafa07ea5f Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Aug 10 '22 08:08 flinkbot

@flinkbot run azure

Sxnan avatar Aug 11 '22 06:08 Sxnan

@flinkbot run azure

Sxnan avatar Aug 11 '22 07:08 Sxnan

@flinkbot run azure

Sxnan avatar Sep 02 '22 08:09 Sxnan

@flinkbot run azure

Sxnan avatar Sep 02 '22 13:09 Sxnan

Merged on master and 1.16, closed.

gaoyunhaii avatar Sep 08 '22 03:09 gaoyunhaii