flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-28899][table-planner] Fix LOOKUP hint with retry option on async lookup mode

Open lincoln-lil opened this issue 3 years ago • 1 comments

What is the purpose of the change

FLINK-28848 introduces a new LOOKUP hint to support retry both on sync and async lookup, but the async path doesn't works because of two reasons: 1. AsyncLookupJoinRunner has a 'stateful' resultFutureBuffer (which is very important for performance) bind to each input record (it's non-reenter-able) 2. can not lookup new value if cache empty values enabled when chained with the new AsyncCachingLookupFunction. So this can not be done by directly enabling retry on 'AsyncWaitOperator', so similar to sync lookup join with retry, we fix this by using a 'RetryableAsyncLookupFunctionDelegator' to support retry.

Brief change log

  • fix async lookup it case with retry
  • add new RetryableAsyncLookupFunctionDelegator

Verifying this change

  • RetryableAsyncLookupFunctionDelegatorTest
  • AsyncLookupJoinITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

lincoln-lil avatar Aug 10 '22 07:08 lincoln-lil

CI report:

  • 1e878d1953a5b3c8aa479ae281ee0fb3cc402c16 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Aug 10 '22 07:08 flinkbot