flink icon indicating copy to clipboard operation
flink copied to clipboard

Published 20 hours ago • verified publisher icon apache

[FLINK-28780][docs] fix incorrect description of function dayofmonth.

Open liuyongvs opened this issue 3 years ago • 3 comments

What is the purpose of the change

fix incorrect description of function dayofmonth

liuyongvs avatar Aug 02 '22 12:08 liuyongvs

CI report:

  • e9849329ea6fc0bb7df1821039a6fcac6d0f2e03 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Aug 02 '22 12:08 flinkbot

hi @snuyanzin ci passed

liuyongvs avatar Aug 03 '22 04:08 liuyongvs

lgtm from my side however i'm not a committer => i can't merge

Meanwhile the thing that could be improved and probably could be asked by committers is explicitly mentioning where description is fixed + filling PR form according to template. Also this link might be useful https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html

snuyanzin avatar Aug 03 '22 12:08 snuyanzin

@snuyanzin is right. Would be better to follow the description template especially when the PR is not a simple hotfix.

wuchong avatar Aug 17 '22 09:08 wuchong