apache
[FLINK-28475] [Connector/kafka] stopping offset can be 0
What is the purpose of the change
Stopping offset can be 0.When we make a zero stopping offset empty,it would be serialized to NO_STOPPING_OFFSET, which it is not expected. It' had been fixed in master by https://github.com/apache/flink/pull/20234, now need to merge into release-1.15.
Brief change log
change a stopping offset conditon from '>0' to '>=0'
Verifying this change
Can be verified by: KafkaPartitionSplitReaderTest#testAssignEmptySplit KafkaPartitionSplitSerializerTest
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving): no - The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
CI report:
- a23a601aa81c1200e4243c9e97c234914a7a479f Azure: SUCCESS
Bot commands
The @flinkbot bot supports the following commands:@flinkbot run azurere-run the last Azure build
@leozhangsr Looks like the commit message is not consistent with the one on master branch and not quite descriptive. Could you update the commit message? You can just copy & paste from master.
@leozhangsr Looks like the commit message is not consistent with the one on master branch and not quite descriptive. Could you update the commit message? You can just copy & paste from master.
Thanks for suggestion.Commit message updated.
@PatrickRen Do you have time to handle this rq? and the requests for release-1.14 ,https://github.com/apache/flink/pull/20387
Commit message looks in sync with master As in pull request(https://github.com/apache/flink/pull/20234), PatrickRen asked for another two pull request for release-1.14 and release-1.15, so I made this two pull request(https://github.com/apache/flink/pull/20389,https://github.com/apache/flink/pull/20387), hoping they can be merged. I will be glad to get a reply.
