flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-28475] [Connector/kafka] stopping offset can be 0.

Open leozhangsr opened this issue 3 years ago • 5 comments

What is the purpose of the change

Stopping offset can be 0.When we make a zero stopping offset empty,it would be serialized to NO_STOPPING_OFFSET, which it is not expected. It' had been fixed in master by https://github.com/apache/flink/pull/20234, now need to merge into release-1.14.

Brief change log

change a stopping offset conditon from '>0' to '>=0'

Verifying this change

Can be verified by: KafkaPartitionSplitReaderTest#testAssignEmptySplit KafkaPartitionSplitSerializerTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

leozhangsr avatar Jul 28 '22 15:07 leozhangsr

CI report:

  • efff0ecc753f35ad3980444f319a2109c323c93f Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 28 '22 15:07 flinkbot

It has a Compilation failure here,I will modified it later

leozhangsr avatar Jul 29 '22 05:07 leozhangsr

@flinkbot run azure

leozhangsr avatar Jul 30 '22 13:07 leozhangsr

@flinkbot run azure

leozhangsr avatar Aug 01 '22 02:08 leozhangsr

This mr still not merge yet, can anyone help?

leozhangsr avatar Aug 23 '22 08:08 leozhangsr

Already close since flink0.15

leozhangsr avatar Aug 16 '23 07:08 leozhangsr