flink icon indicating copy to clipboard operation
flink copied to clipboard

[hotfix][annotation] Refine java doc for annotation VisibleForTesting

Open luoyuxia opened this issue 3 years ago • 3 comments

What is the purpose of the change

To refine the java doc for the annotation VisibleForTesting

Brief change log

  • Change This annotations to This annotation

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A

luoyuxia avatar Jul 14 '22 09:07 luoyuxia

CI report:

  • 63685a365478af0b17a0efca721347214ca6087e Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 14 '22 09:07 flinkbot

@MartijnVisser Do you think this change makes sense?

luoyuxia avatar Jul 15 '22 01:07 luoyuxia

@luoyuxia To be honest, I see very little value in this since it's a small but obvious grammar error. To just get this merged, will consume the CI for quite some time, which I think is more valuable to be spent on other PRs.

MartijnVisser avatar Aug 01 '22 13:08 MartijnVisser