flink [Flink 14101][Connectors][Jdbc] SQL Server dialect

What is the purpose of the change

Support Microsoft SQL Server in JDBC connector

Brief change log

Added SqlServerDialect and corresponding helper class

Verifying this change

This change added tests and can be verified as follows:

Added integration tests of using SqlServer as data source
Added integration tests of using SqlServer as data sink
Added unit tests that checks SqlServerDialect produce correct SQL statement

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

Jul 10 '22 08:07 qingwei91

This PR is quite big, I've tried to split the commits by logical grouping, hope that helps

Jul 10 '22 08:07 qingwei91

CI report:

a7ea861640b64676a9f2fecc471dae21154be726 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run azure re-run the last Azure build

Jul 10 '22 08:07 flinkbot

@flinkbot run azure

Jul 11 '22 09:07 qingwei91

@flinkbot run azure

Jul 13 '22 17:07 qingwei91

@flinkbot run azure

Jul 14 '22 07:07 qingwei91

@RocMarshal since you are working on FLIP-239, would you like to review this PR?

Jul 14 '22 10:07 JingGe

Hi JingGe, sure, I will give it a go

Jul 14 '22 13:07 qingwei91

@RocMarshal since you are working on FLIP-239, would you like to review this PR?

Thanks @qingwei91 for the pr and @JingGe for the ping. I'll check it asap.

Jul 15 '22 03:07 RocMarshal

@flinkbot run azure

Jul 15 '22 17:07 qingwei91

@flinkbot run azure

Jul 17 '22 08:07 qingwei91

Hi @RocMarshal will you be able to review this again? I've addressed your comment.

Thanks for your help!

Jul 23 '22 08:07 qingwei91

@fpompermaier Do you also want to have another look at this PR?

Jul 29 '22 09:07 MartijnVisser

Hi @JingGe , do we just need 1 more review on this?

Aug 15 '22 20:08 qingwei91

@qingwei91 would you like to do the following clean-up:

squash commits and please make sure the commit message follows Flink rule.
rebase to the master.
Replace "[Flink 14101]" with "[Flink-14101]" in the PR title.

Thanks for your effort!

Aug 16 '22 21:08 JingGe

Hi @JingGe thanks for the feedback, I've done the 1st and 2nd point.

But I don't know how to execute the 3rd point, I don't think it supports Markdown in PR title, maybe I am missing something

Aug 20 '22 06:08 qingwei91

Hi @qingwei91 It would be great if you could squash three commits into one.

The PR title just missed "-".

Aug 23 '22 09:08 JingGe

@JingGe sorry I misunderstood, I've fixed it now

Aug 25 '22 06:08 qingwei91

Hi @JingGe thanks for the approval, what else do we need to be able to merge this? Should I reach out to other contributor/committer?

Aug 31 '22 17:08 qingwei91

Since we are currently in feature freeze, this can only be merged when the release branch is cut in the next week or so

Aug 31 '22 18:08 MartijnVisser

@MartijnVisser 1.16 branch has been cut today. This PR could be merged now. Thanks!

Sep 05 '22 10:09 JingGe

@PatrickRen Would you like to merge this PR? Thanks!

Sep 07 '22 07:09 JingGe

Thanks @qingwei91 for the PR and everyone for the reviewing and tracking! I could help merging the PR~

Sep 07 '22 07:09 gaoyunhaii

Merge on master.

Sep 07 '22 08:09 gaoyunhaii