flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

Open X-czh opened this issue 3 years ago • 2 comments

What is the purpose of the change

Help user locate the container where a task is running on from Web UI by including port in the host info on Web UI.

Brief change log

Include port as part of the host info in SubtaskExecutionAttemptDetailsInfo.

Verifying this change

This change is already covered by existing tests, such as SubtaskCurrentAttemptDetailsHandlerTest.testHandleRequest().

Also manually verified the change by running a cluster.

Screenshot from 2022-08-07 19-42-07

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) yes
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented

X-czh avatar Jul 09 '22 10:07 X-czh

CI report:

  • bd0288af873bbc8e4cef410d565f2490f1de434b Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 09 '22 10:07 flinkbot

@flinkbot run azure

X-czh avatar Jul 11 '22 03:07 X-czh

The screenshot displays the task manager panel. You may need to upload the subtasks information.

huwh avatar Aug 08 '23 02:08 huwh

The screenshot displays the task manager panel. You may need to upload the subtasks information.

Thanks for the comment. I've updated the MR description with the screenshot of the subtask info page.

X-czh avatar Aug 08 '23 03:08 X-czh

@huwh Could you help review it again when you are free? Much appreciated.

X-czh avatar Aug 09 '23 16:08 X-czh

location

Hi @1996fanrui, Thanks for the suggestion and I agree with that. How about using "Host:port" in the title in both the subtask details panel and tasks manager details panel?

X-czh avatar Aug 13 '23 08:08 X-czh

How about using "Host:port" in the title in both the subtask details panel and tasks manager details panel?

Sounds make sense to me.

1996fanrui avatar Aug 13 '23 12:08 1996fanrui

@huwh @1996fanrui I've updated the PR with two new commits that aligns the behavior of pretty printing taskmanager locations and updates the Web UI accordingly. Please help review again when you are free, thanks~

X-czh avatar Sep 05 '23 04:09 X-czh

closed due to duplicating with "https://issues.apache.org/jira/browse/FLINK-33146".

huwh avatar Nov 09 '23 11:11 huwh