flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-27473] Introduce Generic Metrics For Job States

Open atris opened this issue 3 years ago • 4 comments

This commit introduces a new type of metrics and extends it to replace the existing deployment metrics, and introduces initialization time metrics.

A new wrapper is introduced, which creates two metrics, one for deployment and one for initialization. Both are created using the new metric type. Any future metrics should be introduced in the wrapper itself.

atris avatar Jul 06 '22 18:07 atris

CI report:

  • f9640549b59ad81bdfac5df24fc2a782a56aa5f8 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 06 '22 18:07 flinkbot

@zentol Thank you for reviewing the changes. I have raised an iteration -- please see and let me know your thoughts.

atris avatar Jul 08 '22 09:07 atris

@zentol Ping. Please let me know your thoughts and comments.

atris avatar Aug 21 '22 16:08 atris

I made a pass over the PR and prepared a significant set of changes here: https://github.com/atris/flink/pull/1

I know that this isn't the ideal approach; but otherwise we would've had to go through a lot of iterations (as I just did on my own; kept finding more things that could be changed :see_no_evil:).

zentol avatar Sep 08 '22 16:09 zentol

@zentol Somehow this PR fell off my radar. I have updated it now with your commit -- can we please proceed?

atris avatar Jul 24 '23 18:07 atris