flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-27660][table] add table api for registering function with resource

Open HuangZhenQiu opened this issue 3 years ago • 9 comments

What is the purpose of the change

Add table api for registering function with remote resource, so that we the advance function creation can be supported in DDL.

Brief change log

  1. Change on Table API with new create function with resources
  2. Add test case in TableEnvironmentImplTest

Verifying this change

The PR is tested in the new test function in TableEnvironmentImplTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

HuangZhenQiu avatar Jul 06 '22 06:07 HuangZhenQiu

CI report:

  • 85f55acde3d6e990ac5c9135e8699ed61c43b961 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 06 '22 06:07 flinkbot

@HuangZhenQiu After https://github.com/apache/flink/pull/20001 merge, you can rebase master, and I will review

lsyldliu avatar Jul 07 '22 03:07 lsyldliu

@lsyldliu Sure. I will rebase later.

HuangZhenQiu avatar Jul 07 '22 03:07 HuangZhenQiu

@flinkbot run azure

HuangZhenQiu avatar Jul 08 '22 16:07 HuangZhenQiu

@HuangZhenQiu The previous PR is already merge into master branch, you can continue this work.

lsyldliu avatar Jul 20 '22 09:07 lsyldliu

@lsyldliu Sure. I will work on it tonight

HuangZhenQiu avatar Jul 20 '22 15:07 HuangZhenQiu

cc @lsyldliu , could you help to review this?

wuchong avatar Jul 22 '22 09:07 wuchong

cc @lsyldliu , could you help to review this?

OKay

lsyldliu avatar Jul 24 '22 12:07 lsyldliu

@lsyldliu Thanks for the review. Revised the code accordingly Would you please take a look again?

HuangZhenQiu avatar Aug 01 '22 04:08 HuangZhenQiu

@lsyldliu , could you help to continue review this PR when you are free?

wuchong avatar Aug 17 '22 02:08 wuchong

@lsyldliu , could you help to continue review this PR when you are free?

LGTM overall just left one comment.

lsyldliu avatar Aug 20 '22 08:08 lsyldliu

@HuangZhenQiu Regarding the failed test, please rebase master branch again.

lsyldliu avatar Aug 31 '22 03:08 lsyldliu