flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-28347][Test infrastructure] Update testcontainers dependency to v1.17.3

Open MartijnVisser opened this issue 3 years ago • 4 comments

What is the purpose of the change

  • Update Testcontainers to latest version

Brief change log

  • Updated version in POM

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Kernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

MartijnVisser avatar Jul 01 '22 09:07 MartijnVisser

@snuyanzin Do you want to make a review?

MartijnVisser avatar Jul 01 '22 09:07 MartijnVisser

CI report:

  • 6b3efc44fce5efd69837f217ee574d001214591e Azure: SUCCESS
  • 6d3b119d6de1d0e72bf9bff29735caba44944aa1 Azure: PENDING
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 01 '22 09:07 flinkbot

Yes, sure. LGTM as soon as tests are green

snuyanzin avatar Jul 01 '22 10:07 snuyanzin

@flinkbot run azure

MartijnVisser avatar Jul 01 '22 13:07 MartijnVisser

I'm honestly still baffled why this patch is failing on our CI while passing locally. @xcomp @snuyanzin if you have any thoughts...

MartijnVisser avatar Oct 20 '22 10:10 MartijnVisser

i will try to have a look including the changeset of testcontainers

snuyanzin avatar Oct 20 '22 14:10 snuyanzin

not 100% sure it seems like a kind of leak, same test is passing if it is running alone on ci need to have a look deeper

snuyanzin avatar Nov 02 '22 08:11 snuyanzin

@MartijnVisser seems I found the reason It looks the issue was in inconsistent jna dependency provided by flink-end-to-end-tests. At the same time testcontainers 1.17.6. depends on docker-java-transport-zerodep 3.2.13 which depends on jna 5.8.0

[INFO] +- org.testcontainers:junit-jupiter:jar:1.17.6:test
[INFO] |  \- org.testcontainers:testcontainers:jar:1.17.6:test
[INFO] |     +- org.apache.commons:commons-compress:jar:1.21:test
[INFO] |     +- org.rnorth.duct-tape:duct-tape:jar:1.0.8:test
[INFO] |     |  \- org.jetbrains:annotations:jar:17.0.0:test
[INFO] |     +- com.github.docker-java:docker-java-api:jar:3.2.13:test
[INFO] |     |  \- com.fasterxml.jackson.core:jackson-annotations:jar:2.13.4:test
[INFO] |     \- com.github.docker-java:docker-java-transport-zerodep:jar:3.2.13:test
[INFO] |        +- com.github.docker-java:docker-java-transport:jar:3.2.13:test
[INFO] |        \- net.java.dev.jna:jna:jar:5.8.0:test

by the way since 5.7.0 contains fixes for M1 it could potentially improve situation with tests on M1 (I can not check it)

snuyanzin avatar Mar 29 '23 05:03 snuyanzin

It looks the issue was in inconsistent jna dependency provided by flink-end-to-end-tests.

Quite a nice find!

by the way since 5.7.0 contains fixes for M1 it could potentially improve situation with tests on M1 (I can not check it)

I'll check it later.

I think you can squash your commit on the JNA comment with the JNA commit and then it should be good to go. I can't approve it (since this is my PR), but if you're also OK with it then we can approve and merge it

MartijnVisser avatar Mar 30 '23 07:03 MartijnVisser