flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-27936][tests] Migrate flink-connector-cassandra to JUnit5

Open snuyanzin opened this issue 3 years ago • 5 comments

What is the purpose of the change

Migrate WriteAheadSinkTestBase and flink-connector-cassandra module to AssertJ and JUnit 5 following the JUnit 5 Migration Guide

Brief change log

Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest

Verifying this change

This change is a code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no )
  • If yes, how is the feature documented? (not applicable)

snuyanzin avatar Jun 08 '22 20:06 snuyanzin

CI report:

  • 8eb8f795e822aafad2604efddab37c51d1bd27c2 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jun 08 '22 20:06 flinkbot

@flinkbot run azure

snuyanzin avatar Jun 09 '22 04:06 snuyanzin

@flinkbot run azure

snuyanzin avatar Jun 09 '22 05:06 snuyanzin

@flinkbot run azure

snuyanzin avatar Aug 03 '22 18:08 snuyanzin

@flinkbot run azure

snuyanzin avatar Aug 08 '22 06:08 snuyanzin

@flinkbot run azure

snuyanzin avatar Aug 17 '22 10:08 snuyanzin

@flinkbot run azure

snuyanzin avatar Sep 06 '22 23:09 snuyanzin

@flinkbot run azure

snuyanzin avatar Sep 08 '22 08:09 snuyanzin

I also rebased to the latest master to avoid FLINK-29161

snuyanzin avatar Sep 09 '22 09:09 snuyanzin

The CI test failure is most likely connected to FLINK-29093

snuyanzin avatar Sep 09 '22 19:09 snuyanzin

@flinkbot run azure

snuyanzin avatar Sep 09 '22 19:09 snuyanzin