flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-27758][tests][table] Migrate flink-table-runtime to JUnit5

Open snuyanzin opened this issue 3 years ago • 4 comments

What is the purpose of the change

Update the flink-table-runtime module to AssertJ and JUnit 5 following the JUnit 5 Migration Guide

Brief change log

Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest

Verifying this change

This change is a code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

snuyanzin avatar May 24 '22 20:05 snuyanzin

CI report:

  • 035844d9f808217fa24b9252e7e36fe225d58ef3 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 24 '22 20:05 flinkbot

@flinkbot run azure

snuyanzin avatar May 25 '22 03:05 snuyanzin

~~The PR is based on PR/commit https://github.com/apache/flink/pull/19780 migrating TypeSerializerUpgradeTestBase to JUnit5~~ rebased on master

snuyanzin avatar May 25 '22 05:05 snuyanzin

@Jiabao-Sun since you are one of those who is active in junit4-junit5 migration may I ask you to have a look here?

snuyanzin avatar Aug 28 '24 19:08 snuyanzin

thanks a lot for taking a look

snuyanzin avatar Aug 30 '24 06:08 snuyanzin