flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-27074] Change python_job.py to write to unique paths within TEST_DATA_DIR

Open twthorn opened this issue 3 years ago • 2 comments

What is the purpose of the change

Change python_job.py to use the shared TEST_DATA_DIR environment variable & directory for writing test output data (rather than its current custom logic for creating/removing an output directory). Also, generates a unique directory name within TEST_DATA_DIR so e2e tests that use this file multiple times do not run into name conflicts.

Brief change log

  • Change python_job.py to write to unique paths within TEST_DATA_DIR

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

twthorn avatar May 13 '22 16:05 twthorn

CI report:

  • 9df66fdad3309e0e5ad33ffe656a07760e1eaa68 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 13 '22 16:05 flinkbot

@MartijnVisser Can you review this when you get the chance or know someone who could? Issue is a bit old but still open, and the file hasn't been changed since before this PR was created, so it's still up to date.

twthorn avatar Jun 19 '24 15:06 twthorn

This PR is being marked as stale since it has not had any activity in the last 180 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

github-actions[bot] avatar Jan 15 '25 06:01 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Mar 31 '25 06:03 github-actions[bot]